Codespace Creation has a pipe as STDIN and this can block certain scripts which check STDIN, such as as jorgebucaran/fisher

[vorburger]

I use https://docs.github.com/en/codespaces/customizing-your-codespace/personalizing-github-codespaces-for-your-account#dotfiles for https://github.com/vorburger/vorburger-dotfiles-bin-etc.

The GitHub Codespaces: Configuration view contains:

Use Cmd/Ctrl + Shift + P -> View Creation Log to see full logs
✔ Finishing up...
✔ Running postCreateCommand...
⠹ Installing Dotfiles

The GitHub Codespaces: Details view contains:

[205724 ms] go: downloading golang.org/x/sys v0.0.0-20210110051926-789bb1bd4061
[206745 ms] + '[' -s /home/codespace/.config/fish/functions/fisher.fish ']'
[206745 ms] + fish -c 'curl -sL https://git.io/fisher | source && fisher install jorgebucaran/fisher'

It stops abruptly there, even though it hasn't finished; I suspect there is an (undocumented...) inherent timeout for customizing Codespace with dotfiles scripts?

It would be great if this timeout could be increased!

In the meantime, one can (has to...) make my bootstrap.sh shorter, of course.

[vorburger]

Actually I may have misinterpreted what's happening here... is this not a timeout but a sort of premature uncaught termination?

I think this would reproduce even if JUST doing fish -c 'curl -sL https://git.io/fisher | source && fisher install jorgebucaran/fisher' - how can this possible trip over Codespace customization?

Is there some "magic" going on that detects that Fish launched?!

[legomushroom]

@vorburger we don't discriminate against Fish shells or any other shell you might want to use. What exactly happens when you do fish -c 'curl -sL https://git.io/fisher | source && fisher install jorgebucaran/fisher' directly? Do you see any errors or the Codespace disconnects?

If later, that might be an out-of-memory killer to kick in, doing dmesg -T | egrep -i 'killed process' might reveal some clues in that case.

[vorburger]

@vorburger we don't discriminate against Fish shells or any other shell you might want to use.

Good to know 😸

What exactly happens when you do fish -c 'curl -sL https://git.io/fisher | source && fisher install jorgebucaran/fisher' directly? Do you see any errors or the Codespace disconnects?

Interestingly, that "just works", and is very quick also, see:

$ time fish -c "source /tmp/fisher && fisher install jorgebucaran/fisher"
fisher install version 4.4.2
Fetching https://api.github.com/repos/jorgebucaran/fisher/tarball/HEAD
Installing jorgebucaran/fisher
           /home/codespace/.config/fish/functions/fisher.fish
           /home/codespace/.config/fish/completions/fisher.fish
Updated 1 plugin/s

real    0m0.395s
user    0m0.115s
sys     0m0.075s

If later, that might be an out-of-memory killer to kick in, doing dmesg -T | egrep -i 'killed process' might reveal some clues in that case.

Ah yes interesting idea, I checked but it doesn't look like that's it... there's nothing in dmesg - and this ps auxwwwwwwwwwww shows that fish -c source /tmp/fisher && fisher install jorgebucaran/fisher seems to just "hang" (it wasn't killed).

USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root         1  0.0  0.0   1080     4 ?        Ss   11:35   0:00 /sbin/docker-init -- /bin/sh -c echo Container started trap "exit 0" 15  exec "$@" while sleep 1 & wait $!; do :; done - /usr/local/share/docker-init.sh /usr/local/share/ssh-init.sh sleep infinity
root         7  0.0  0.0   2508   580 ?        S    11:35   0:00 sleep infinity
root        42  0.0  0.6 1517272 50076 ?       Sl   11:35   0:00 dockerd --dns 168.63.129.16
root        88  0.0  0.0  12176  2848 ?        Ss   11:35   0:00 sshd: /usr/sbin/sshd [listener] 0 of 10-100 startups
root       130  0.0  0.6 1419664 49760 ?       Ssl  11:35   0:00 containerd --config /var/run/docker/containerd/containerd.toml --log-level info
codespa+  1353  0.0  0.0   2608  1788 ?        Ss   11:36   0:00 /bin/sh
root      1450  0.0  0.0   2608   532 ?        Ss   11:36   0:00 /bin/sh
codespa+  1812  0.0  0.0   2608  1640 ?        Ss   11:36   0:00 /bin/sh
codespa+  2344  0.0  0.0   2616   600 ?        Ss   11:36   0:00 sh /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/server.sh --log trace --force-disable-user-env --server-data-dir /home/codespace/.vscode-remote --accept-server-license-terms --host 127.0.0.1 --port 0 --connection-secret /home/codespace/.vscode-remote/data/Machine/.connection-token-56f631257cfafdd76acbf062654ae4d8ad32e221-insider --extensions-download-dir /home/codespace/.vscode-remote/extensionsCache --install-builtin-extension GitHub.vscode-pull-request-github --install-builtin-extension github.github-vscode-theme --install-builtin-extension github.codespaces --do-not-sync --start-server  --enable-remote-auto-shutdown
codespa+  2357  8.6  1.3 962836 106176 ?       Sl   11:36   0:27 /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/out/server-main.js --compatibility=1.63 --log trace --force-disable-user-env --server-data-dir /home/codespace/.vscode-remote --accept-server-license-terms --host 127.0.0.1 --port 0 --connection-secret /home/codespace/.vscode-remote/data/Machine/.connection-token-56f631257cfafdd76acbf062654ae4d8ad32e221-insider --extensions-download-dir /home/codespace/.vscode-remote/extensionsCache --install-builtin-extension GitHub.vscode-pull-request-github --install-builtin-extension github.github-vscode-theme --install-builtin-extension github.codespaces --do-not-sync --start-server  --enable-remote-auto-shutdown
codespa+  2492  1.3  0.7 678420 64004 ?        Rl   11:36   0:04 /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/out/bootstrap-fork --type=ptyHost --logsPath /home/codespace/.vscode-remote/data/logs/20221012T113617
codespa+  2512  0.3  0.5 587760 45660 ?        Rsl  11:36   0:01 /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node -e  ????const net = require('net'); ????const fs = require('fs'); ????process.stdin.pause(); ????const client = net.createConnection({ host: '127.0.0.1', port: 39329 }, () => { ?????console.error('Connection established'); ?????client.pipe(process.stdout); ?????process.stdin.pipe(client); ????}); ????client.on('close', function (hadError) { ?????console.error(hadError ? 'Remote close with error' : 'Remote close'); ?????process.exit(hadError ? 1 : 0); ????}); ????client.on('error', function (err) { ?????process.stderr.write(err && (err.stack || err.message) || String(err)); ????}); ????process.stdin.on('close', function (hadError) { ?????console.error(hadError ? 'Remote stdin close with error' : 'Remote stdin close'); ?????process.exit(hadError ? 1 : 0); ????}); ????process.on('uncaughtException', function (err) { ?????fs.writeSync(process.stderr.fd, `Uncaught Exception: ${String(err && (err.stack || err.message) || err)}\n`); ????}); ???
codespa+  2548  0.4  0.5 584236 42828 ?        Ssl  11:36   0:01 /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node -e  ????const net = require('net'); ????const fs = require('fs'); ????process.stdin.pause(); ????const client = net.createConnection({ host: '127.0.0.1', port: 39329 }, () => { ?????console.error('Connection established'); ?????client.pipe(process.stdout); ?????process.stdin.pipe(client); ????}); ????client.on('close', function (hadError) { ?????console.error(hadError ? 'Remote close with error' : 'Remote close'); ?????process.exit(hadError ? 1 : 0); ????}); ????client.on('error', function (err) { ?????process.stderr.write(err && (err.stack || err.message) || String(err)); ????}); ????process.stdin.on('close', function (hadError) { ?????console.error(hadError ? 'Remote stdin close with error' : 'Remote stdin close'); ?????process.exit(hadError ? 1 : 0); ????}); ????process.on('uncaughtException', function (err) { ?????fs.writeSync(process.stderr.fd, `Uncaught Exception: ${String(err && (err.stack || err.message) || err)}\n`); ????}); ???
codespa+  2986  0.0  0.0   3896  2900 ?        S    11:36   0:00 bash ./bootstrap.sh
codespa+  3200  0.0  0.0   2608  1632 ?        Ss   11:36   0:00 /bin/sh
root      3256  0.0  0.0   2608   532 ?        Ss   11:36   0:00 /bin/sh
codespa+  3274  0.0  0.0   3896  2764 ?        S    11:36   0:00 bash ./ubuntu-install.sh
codespa+  4019  0.0  0.5 835508 43524 ?        Sl   11:36   0:00 /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/out/bootstrap-fork --type=fileWatcher
codespa+  4043  6.4  2.9 11579896 237332 ?     Sl   11:36   0:20 /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/out/bootstrap-fork --type=extensionHost --transformURIs --useHostProxy=false
codespa+  4056  0.0  0.0   2608  1628 ?        Ss   11:36   0:00 /bin/sh
root      4136  0.0  0.0   2608   528 ?        Ss   11:36   0:00 /bin/sh
codespa+  4905  0.0  0.5 589400 41880 ?        Sl   11:36   0:00 /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/extensions/markdown-language-features/server/dist/node/main --node-ipc --clientProcessId=4043
codespa+  5735  0.0  0.0   2608  1716 ?        Ss   11:36   0:00 /bin/sh
root      5815  0.0  0.0   2608   596 ?        Ss   11:36   0:00 /bin/sh
codespa+  6171  0.0  0.4 319248 34280 ?        Ssl  11:36   0:00 /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node -e  ????const net = require('net'); ????const fs = require('fs'); ????process.stdin.pause(); ????const client = net.createConnection({ host: '127.0.0.1', port: 39329 }, () => { ?????console.error('Connection established'); ?????client.pipe(process.stdout); ?????process.stdin.pipe(client); ????}); ????client.on('close', function (hadError) { ?????console.error(hadError ? 'Remote close with error' : 'Remote close'); ?????process.exit(hadError ? 1 : 0); ????}); ????client.on('error', function (err) { ?????process.stderr.write(err && (err.stack || err.message) || String(err)); ????}); ????process.stdin.on('close', function (hadError) { ?????console.error(hadError ? 'Remote stdin close with error' : 'Remote stdin close'); ?????process.exit(hadError ? 1 : 0); ????}); ????process.on('uncaughtException', function (err) { ?????fs.writeSync(process.stderr.fd, `Uncaught Exception: ${String(err && (err.stack || err.message) || err)}\n`); ????}); ???
codespa+  6197  0.0  0.3 319248 32196 ?        Ssl  11:36   0:00 /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node -e  ????const net = require('net'); ????const fs = require('fs'); ????process.stdin.pause(); ????const client = net.createConnection({ host: '127.0.0.1', port: 39329 }, () => { ?????console.error('Connection established'); ?????client.pipe(process.stdout); ?????process.stdin.pipe(client); ????}); ????client.on('close', function (hadError) { ?????console.error(hadError ? 'Remote close with error' : 'Remote close'); ?????process.exit(hadError ? 1 : 0); ????}); ????client.on('error', function (err) { ?????process.stderr.write(err && (err.stack || err.message) || String(err)); ????}); ????process.stdin.on('close', function (hadError) { ?????console.error(hadError ? 'Remote stdin close with error' : 'Remote stdin close'); ?????process.exit(hadError ? 1 : 0); ????}); ????process.on('uncaughtException', function (err) { ?????fs.writeSync(process.stderr.fd, `Uncaught Exception: ${String(err && (err.stack || err.message) || err)}\n`); ????}); ???
codespa+  6332  0.0  0.0   2612   536 pts/0    Ss+  11:36   0:00 /bin/sh -c $(which ~/.vscode-remote/bin/*/node | head -n 1) /workspaces/.codespaces/shared/codespaceStatusTool.js
codespa+  6337  0.5  0.5 620516 47952 pts/0    Sl+  11:36   0:01 /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node /workspaces/.codespaces/shared/codespaceStatusTool.js
codespa+  7742  0.0  0.1  14656 11636 pts/3    Ss   11:36   0:00 /usr/bin/bash --init-file /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/out/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh
codespa+  9326  0.0  0.0   3896  2804 ?        S    11:37   0:00 bash ./apt-install.sh
codespa+  9343  0.0  0.0   5756   812 pts/3    S+   11:37   0:00 dmesg -Tw
codespa+ 10120  0.0  0.0   3896  2992 ?        S    11:38   0:00 bash ./all-install.sh
codespa+ 10124  0.0  0.0 159816  7000 ?        S    11:38   0:00 fish -c source /tmp/fisher && fisher install jorgebucaran/fisher
codespa+ 10366  0.0  0.1  14656 11588 pts/1    Ss   11:38   0:00 /usr/bin/bash --init-file /vscode/bin/linux-x64/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/out/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh
codespa+ 12676  0.0  0.0   8892  3224 pts/1    R+   11:41   0:00 ps auxwwwwwwwwwww

FYI there is also a "pop-up" message in the lower right hand corner that says "The terminal process failed to launch: Path to shell executable "/usr/bin/fish" does not exist." but that appears "early" (before it gets stuck on fisher), and likely is because my script initially does an sudo apt-get remove -y fish fish-common to then re-install a newer Fish version; I doubt that's related to this.

Let me try to create a simple standalone new git repo which reproduces this issue.

[vorburger]

Let me try to create a simple standalone new git repo which reproduces this issue.

@legomushroom https://github.com/vorburger/dotfiles-reproduce-problem easily reproduces it! Pick that as your repo to Automatically install dotfiles on https://github.com/settings/codespaces and... voilà - the workspace creation strangely "hangs", as described here.

[vorburger]

The creation.log seems to show that Fish somehow gets stuck on iothread: pthread 0x7f9125dd9700 exiting - which works when bootstrap.sh is called "directly."

[vorburger]

I figured out that it's because fisher when it runs non-interactively attempts to read STDIN and this blocks in a GitHub Codespace setup.sh because there STDIN is set to a pipe.

See jorgebucaran/fisher#742 and https://github.com/vorburger/dotfiles-reproduce-problem.

[NicolasRouquette]

Is it normal to see processes with strings like this: ????

codespa+  2512  0.3  0.5 587760 45660 ?        Rsl  11:36   0:01 /home/codespace/.vscode-remote/bin/56f631257cfafdd76acbf062654ae4d8ad32e221-insider/node -e  ????const net = require('net'); ????const fs = require('fs'); ????process.stdin.pause(); ????const client = net.createConnection({ host: '127.0.0.1', port: 39329 }, () => { ?????console.error('Connection established'); ?????client.pipe(process.stdout); ?????process.stdin.pipe(client); ????}); ????client.on('close', function (hadError) { ?????console.error(hadError ? 'Remote close with error' : 'Remote close'); ?????process.exit(hadError ? 1 : 0); ????}); ????client.on('error', function (err) { ?????process.stderr.write(err && (err.stack || err.message) || String(err)); ????}); ????process.stdin.on('close', function (hadError) { ?????console.error(hadError ? 'Remote stdin close with error' : 'Remote stdin close'); ?????process.exit(hadError ? 1 : 0); ????}); ????process.on('uncaughtException', function (err) { ?????fs.writeSync(process.stderr.fd, `Uncaught Exception: ${String(err && (err.stack || err.message) || err)}\n`); ????}); ???

Can someone explain what this means?