code search is inaccurate and does not show all exact matches

[braedontask]

Select Topic Area

Bug

Body

issue
when searching in my company's repository for an exact string (in my case: ExternalEntityIngestionService in get-wrecked/medal-backend) it only delivers 2 of 3 results. ironically, it excludes the definition of this class from the search.

i presume this might be bug in indexing but ive tried searching with the repo:get-wrecked/medal-backend and the repository isnt new (as other discussion items mentioned). hoping this isnt widespread :)

emotional context
after leaving meta im highly dependent on strong code search for due diligence on auditing backend callsites. its pretty frightening to get an inconsistent result on code search. i dont want to live in fear.

[look]

Apologies for the frustration. I looked into this and I believe the file is being excluded because one of its path components (/external/) triggers our vendored code detection. Unfortunately, there's no work around right now, but I raised the issue to the team for feedback. We're hoping to index all code (or at least, more of it) in the future.

[braedontask]

thanks for the response! that information is certainly better than not knowing why the results are inconsistent 👍🏾

after reading this post on the new search engine... i am curious how much memory is saved by not indexing vendored code?

[Dunedan]

@look We have the same issue in one of our repository with results from a sub-directory called vendor (which actually doesn't contain vendored code) not being shown in the search results.

If Githubs "vendored code detection" just relies on matching of the path, that's obviously leading to lots of false positives being excluded from search.

[mcobbice]

What is going on here? Why does github not find any results when I have literally copy-pasted a search term from a repo?

Video.Project.mp4

[look]

Hi @mcobbice. Sorry for the confusion, but GitHub code search only indexes the default branch (see the limitations documentation). You're looking at a tag. I think on the main branch that function is now zbx_dc_sync_configuration.

[mcobbice]

Ah I see, that makes sense. Thank you for the explanation