SocketAddress undocumented exception

[rejetto]

hi!
I've just discovered that "new SocketAddress" can throw ERR_INVALID_ADDRESS.
I checked the documentation, and it says nothing about it.
Is this supposed to be considered a problem of the documentation of SocketAddress, or are exceptions normally not documented?
Thanks

[RedYetiDev]

Can you provide a minimal reproducible example?

[rejetto]

i can't remember what was the case at the time, but this does it

new (require('net').SocketAddress)({ address: '1' })

[RedYetiDev]

Fixed by #54661

[rejetto]

I saw you added the exception to the general list of errors.
I didn't even notice it was missing from there.
I hoped to get the list of possible exceptions of a specific function to be mentioned by the documentation of that function, so that I can decide to write code that will handle all the cases specifically. It seems that I have to write generic catch-code, and go trial-and-error to know what exceptions will I meet, forever fearing I didn't cover all the cases adequately.

[RedYetiDev]

@nodejs/net WDYT about this

[ShogunPanda]

I don't think is very doable.
While this might be a good idea from day zero, it's quite impossible to add the specific list of all possible exceptions to every API to a 15 years old codebase. It's not just a matter of time effort, but it also about following all possible code paths (think, for instance, about node:https which subclasses node:http and uses node:tls, both of which subclass node:net).

Writing generic code is the way to go unfortunately. But unless you don't validate user input in advance I think you should not expect Node.js API to throw errors on regular behaviors.