Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS2430 Support #55

Merged
merged 10 commits into from
Oct 8, 2022
Merged

DS2430 Support #55

merged 10 commits into from
Oct 8, 2022

Conversation

Siarhei-Hanchuk
Copy link
Contributor

No description provided.

@orgua
Copy link
Owner

orgua commented Jul 23, 2018

ok, saw no need for this before, but will test and come back to this.
just as a note for me:

  • header of .h still contains information of ds2431

@orgua orgua mentioned this pull request Jul 23, 2018
Open
@Siarhei-Hanchuk
Copy link
Contributor Author

I have removed unnecessary code, but one travis's test is fail. I can't understand why

@orgua
Copy link
Owner

orgua commented Dec 29, 2019

@Giermann is right, the core code should not be altered in this PR. Your Problem is not connected with this part of the code after the search. Look at OneWireHub::Poll() and you will see that we will stay in the while-loop when recvAndProcess() is returned with False. Totally wanted behavior! What kind of Master are your using?

There are two more steps:

  • an example arduino code would be nice
  • the readme.md should reflect the new sensor

orgua
orgua reviewed Oct 8, 2022
View reviewed changes
src/OneWireHub.cpp Outdated
@@ -420,6 +420,7 @@ bool OneWireHub::recvAndProcessCmd(void)

slave_selected = nullptr;
searchIDTree();
slave_selected->duty(this);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is that needed? gonna remove this line as it is not default OW-behavior.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, didn't see that before! Sorry, you are totally right, some ICs allow that. Will implement IC-dependent option for that! But will have to disable it for now as it is messing with the other ICs.

@orgua orgua merged commit 80568e4 into orgua:main Oct 8, 2022
@orgua
Copy link
Owner

orgua commented Oct 8, 2022

thanks for the contribution - sorry for the loooooooong delay :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orgua orgua orgua left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siarhei-Hanchuk @orgua @Giermann