Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): display the number of shared libraries #58

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

sumit0190
Copy link
Contributor

Description of change

This change adds support for showing the number of shared libraries when the app starts with a binary. The same logic as used in other such lists is used. Closes #54.

How has this been tested? (if applicable)

Ran the binary with different files to verify that the number of shared libraries shown is correct.

@sumit0190 sumit0190 requested a review from orhun as a code owner September 30, 2024 13:16
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for your contribution!

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 3.35%. Comparing base (3f4f742) to head (5503087).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tui/ui.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #58      +/-   ##
========================================
- Coverage   3.37%   3.35%   -0.02%     
========================================
  Files         19      19              
  Lines       2377    2392      +15     
========================================
  Hits          80      80              
- Misses      2297    2312      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit ad7cca3 into orhun:main Sep 30, 2024
26 of 27 checks passed
@orhun orhun changed the title feat: display number of shared libraries feat(general): display the number of shared libraries Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the number of shared libraries
2 participants