Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flake): add missing meta section to flake #74

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

ch4og
Copy link
Contributor

@ch4og ch4og commented Oct 7, 2024

Description of change

This adds meta section which is needed for example to show description of a package

@ch4og ch4og requested a review from orhun as a code owner October 7, 2024 19:50
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.33%. Comparing base (aba6112) to head (70e747d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #74      +/-   ##
========================================
- Coverage   3.34%   3.33%   -0.01%     
========================================
  Files         19      19              
  Lines       2399    2407       +8     
========================================
  Hits          80      80              
- Misses      2319    2327       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flake.nix Outdated Show resolved Hide resolved
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit 4bc6b7a into orhun:main Oct 8, 2024
26 of 27 checks passed
@orhun
Copy link
Owner

orhun commented Oct 8, 2024

btw, do you know if there are any GitHub actions (or can we hack something together) to test the Nix builds in CI?

@ch4og
Copy link
Contributor Author

ch4og commented Oct 8, 2024

Easiest approach is installing nix package manager onto action

I'll look into it now and will create PR / give you feedback

@orhun
Copy link
Owner

orhun commented Oct 8, 2024

perfect, thanks!

@ch4og
Copy link
Contributor Author

ch4og commented Oct 8, 2024

I did an action that builds flake 50f6acd
but I have no idea how to use rust-cache with nix building system.

After an hour of searching a way I found nothing.
Without rust-cache build takes 5+mins.
https://github.com/ch4og/binsider/actions/runs/11232508090/job/31224245945

The only way I know to fix this is complex full rewrite of flake, that will build cargo crate. I don't have enough knowlege and desire to do it.

Should I create a PR with this half success?

@orhun
Copy link
Owner

orhun commented Oct 8, 2024

Ah, for sure, please go ahead and create a draft PR. I can ping some Nix people for further help :)

Thanks for your effort on this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants