Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the action faster #18

Closed
orhun opened this issue Mar 17, 2024 · 4 comments
Closed

Make the action faster #18

orhun opened this issue Mar 17, 2024 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@orhun
Copy link
Owner

orhun commented Mar 17, 2024

Right now we are building the Docker image for the invocation of git-cliff-action, see Docker container action for more information.

It would be nice to use pre-built git-cliff binaries instead which would be a huge benefit when it comes to the overall speed of the action.

@orhun orhun added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 17, 2024
@tranzystorekk
Copy link

I could add a manifest for git-cliff to https://github.com/taiki-e/install-action but I'm not sure if we can use it as a dependency here

@orhun
Copy link
Owner Author

orhun commented Mar 17, 2024

It's a pretty good idea! Let's do that and offer that as an alternative to using this action.

e.g.

- name: Install git-cliff
  uses: taiki-e/install-action@git-cliff

- name: Generate changelog
  run: git-cliff $args

I don't think using that as a dependency here is the way to go.

@DeadNews
Copy link

Can be installed from PyPI:

- name: Install git-cliff
  run: pipx install git-cliff

- name: Generate changelog
  run: git-cliff $args

ref: orhun/git-cliff#158

@orhun
Copy link
Owner Author

orhun commented Mar 27, 2024

Hey @DeadNews - that's a good trick. Are you also interested in contributing that to the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants