Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for git-cliff #411

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

tranzystorekk
Copy link
Contributor

Adds support for git-cliff, initially discussed in orhun/git-cliff-action#18

I'm not sure if it's a bug or just undocumented behavior, but I couldn't add both gnu and musl targets because the manifest tool removes all gnu targets if they coexist with musl and then errors out later that no gnu targets exits...

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e
Copy link
Owner

taiki-e commented Mar 18, 2024

I'm not sure if it's a bug or just undocumented behavior, but I couldn't add both gnu and musl targets because the manifest tool removes all gnu targets if they coexist with musl and then errors out later that no gnu targets exits...

This is the intended behavior: if both linux-musl and linux-gnu binaries are present, install-action will always install the linux-musl binary for compatibility with older glibc, so there is no need to leave information about the linux-gnu binaries in the final manifest. If all releases have both binaries, the linux-gnu binary is never used, so you will get an error that it is unused.

However, it is indeed not documented in the development guide... (And the error message is probably confusing...)

@taiki-e taiki-e merged commit 0002486 into taiki-e:main Mar 18, 2024
26 checks passed
@tranzystorekk tranzystorekk deleted the add-git-cliff branch March 18, 2024 01:38
@taiki-e
Copy link
Owner

taiki-e commented Mar 18, 2024

Published in 2.29.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants