fix: don't create regex inside a loop #937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the creation of an array of
TextProcessor
objects, that includes the contruction of aRegex
to the outside of a loop. The array is only ever user by reference, so reusing a single instance will produce the same effects.Motivation and Context
The Lints CI check is failing due to the creation of the same Regex within a loop.
How Has This Been Tested?
The change is within the integration tests, and those continue to pass.
Screenshots / Logs (if applicable)
Types of Changes
Checklist:
I have updated the documentation accordingly.I have added tests to cover my changes.