-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "rev" detail to default view of keys #246
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of adding (rev) to the beginning of the entries, we can change the style for preserving the alignment.
src/app/style.rs
Outdated
@@ -1,8 +1,11 @@ | |||
use clap::ValueEnum; | |||
use core::panic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to import stuff from core
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore this, I was using panic for dumb testing. How can I enable tracing logging to STDOUT btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUST_LOG=trace cargo r
doesn't help as the TUI takes over STDOUT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a logging widget in the TUI: https://github.com/orhun/gpg-tui?tab=readme-ov-file#show-logs
You can also save logs to a file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! That's just neat
Any suggestions on changing the style? This is better as it means the tests will have far less breakage (we won't need to revise it) |
Maybe the revoked/invalid/etc keys can be gray or italic, indicating that they are not available. What do you think? |
That's a good idea!! |
Description
Brief POC wip to learn the internals and add "rev" detail to the top level view of keys
Motivation and Context
This helps to quickly visualise what has and has not been revoked. Ideally I plan to add a default filtering option to hide revoked keys,
How Has This Been Tested?
Manually, tests need updating.
Output (if appropriate):
You should see
(rev)
at the top-level view of keys.Types of changes
Checklist:
Outstanding tasks: