Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Toggle Function #63

Merged
merged 12 commits into from
Feb 17, 2022
Merged

Added Toggle Function #63

merged 12 commits into from
Feb 17, 2022

Conversation

JannesStroehlein
Copy link
Contributor

@JannesStroehlein JannesStroehlein commented Dec 3, 2021

Toggle Autoclicker and Auto stop on mouse movement

Currently I'm "playing" lots of CookieClicker and got repeatedly confused about the start/stop buttons - so I added a button that could do both. I also had a few autoclicker mishaps where I moved my mouse with the autoclicker enabled into another window with unintended results. That's why I added a option to stop clicking when the mouse moves.

Both functions work in hand with the existing code base. The new hotkey is editable in the settings window and also gets saved and unregistered. The hotkey id as well as the button label are saved in the Constants.cs file. The new checkbox's value also gets saved and loaded. I also added a slider to change the tolerance of the mouse movement detection.

@JannesStroehlein JannesStroehlein changed the title - added toggle functionality New Toggle Function and Ability to automatically stop Clicking on mouse movement Dec 5, 2021
- added logging of the global mouse hook
- enable/disable controls when they would conflict the settings
- updated UI
- added intelligent tolerance mode
@oriash93
Copy link
Owner

oriash93 commented Dec 6, 2021

@JannesStroehlein Thank you very much for your contribution! I appreciate it 🙏🏽
I will start reviewing your code in the next few days

AutoClicker/Enums/Enums.cs Outdated Show resolved Hide resolved
@JannesStroehlein
Copy link
Contributor Author

The typos should be fixed now.

@oriash93
Copy link
Owner

Hey @JannesStroehlein,

I started to review your code and have some notes:

  • Regarding UI - I consider replacing the "Behaviour" title in the groupbox header to a CheckBox + title ("Stop on mouse move"), and then having the Tolerance Mode ComboBox + Tolerance (pixels) TextBox in the GroupBox itself.
  • When I run the AutoClicker with "Stop on mouse move" turned on and then moving the mouse, the clicking stops but it is not reflected in the UI (buttons for example).
  • Should we define min/max values for the pixels?

@oriash93
Copy link
Owner

@JannesStroehlein hey, I reviewed all code and decided that the toggle feature is great, but the other feature should be split to a separate PR and needs more work.

If you want to continue on it just revert the last commit I pushed (47eea86)

@oriash93 oriash93 changed the title New Toggle Function and Ability to automatically stop Clicking on mouse movement Added Toggle Function Feb 17, 2022
@oriash93 oriash93 merged commit 9e5e781 into oriash93:master Feb 17, 2022
@oriash93 oriash93 added this to the v3.3.0 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants