Distributed: asynchronous inserts ignore unique indexes

[nethertek]

Applying a unique index such as

"create index sms_keys ON SMS (type, lang) unique"

is ignored during inserts in distributed asynchronous mode.

[lvca]

Fixed in 9804c47 and deployed in last 2.0-SNAPSHOT.

[nethertek]

The issue is again present in version 2.0.9, 2.0.12. Whilst the index is created, it is ignored during insert in distributed mode.

Once duplicates have been inserted, rebuilding the index will cause an exception as expected.

[lvca]

I cannot reproduce it. Do you have a test case?

[nethertek]

Creating database [remote:localhost/test] using the storage type [plocal]...
Disconnecting from the database [backnodeee]...OK
Connecting to database [remote:localhost/test] with user 'admin'...OK

DISTRIBUTED CONFIGURATION:
{
  "members": [{
      "id": "57c61537-d5d8-418e-b97a-0867eb5202e3",
      "name": "missouri",
      "startedOn": "2015-07-22 13:04:09",
      "listeners": [{"protocol":"ONetworkProtocolBinary","listen":"50.30.34.105:2424"},{"protocol":"ONetworkProtocolHttpDb","listen":"50.30.34.105:2480"}],
      "databases": []
      },{
      "id": "c72e82e5-d9ef-4571-8b46-c92d82db2abd",
      "name": "tirpitz",
      "startedOn": "2015-07-22 13:06:20",
      "listeners": [{"protocol":"ONetworkProtocolBinary","listen":"148.251.77.75:2424"},{"protocol":"ONetworkProtocolHttpDb","listen":"148.251.77.75:2480"}],
      "databases": []
      }
  ],
  "localName": "_hzInstance_1_orientdb",
  "localId": "c72e82e5-d9ef-4571-8b46-c92d82db2abd"
}
Database created successfully.

Current database is: remote:localhost/test
orientdb {db=test}> create class SMS;

Class created successfully. Total classes in database now: 11

orientdb {db=test}> create property SMS.type string

Property created successfully with id=1

orientdb {db=test}> create property SMS.lang string

Property created successfully with id=2

orientdb {db=test}> create property SMS.source integer

Property created successfully with id=3

orientdb {db=test}> create property SMS.content string

Property created successfully with id=4

orientdb {db=test}> alter property SMS.lang min 2

Property updated successfully

orientdb {db=test}> alter property SMS.lang max 2

Property updated successfully

orientdb {db=test}> create index sms_keys ON SMS (type, lang) unique


Creating index...
Created index successfully with 0 entries in 1.663000 sec(s).


Index created successfully
orientdb {db=test}> 

orientdb {db=test}> insert into sms (type, lang, source, content) values ( 'notify', 'en', 1, 'This is a test');

Inserted record 'SMS#14:0{type:notify,lang:en,source:1,content:This is a test} v1' in 0.014000 sec(s).

orientdb {db=test}> insert into sms (type, lang, source, content) values ( 'notify', 'en', 1, 'This is a test');

Inserted record 'SMS#14:1{type:notify,lang:en,source:1,content:This is a test} v1' in 0.033000 sec(s).

orientdb {db=test}> insert into sms (type, lang, source, content) values ( 'notify', 'en', 1, 'This is a test');

Inserted record 'SMS#14:2{type:notify,lang:en,source:1,content:This is a test} v1' in 0.289000 sec(s).

orientdb {db=test}> insert into sms (type, lang, source, content) values ( 'notify', 'en', 1, 'This is a test');

Inserted record 'SMS#14:3{type:notify,lang:en,source:1,content:This is a test} v1' in 0.005000 sec(s).

orientdb {db=test}> select * from SMS

----+-----+------+------+----+------+--------------
#   |@RID |@CLASS|type  |lang|source|content       
----+-----+------+------+----+------+--------------
0   |#14:0|SMS   |notify|en  |1     |This is a test
1   |#14:1|SMS   |notify|en  |1     |This is a test
2   |#14:2|SMS   |notify|en  |1     |This is a test
3   |#14:3|SMS   |notify|en  |1     |This is a test
----+-----+------+------+----+------+--------------

4 item(s) found. Query executed in 0.007 sec(s).
orientdb {db=test}> rebuild index *


Rebuilding index(es)...
Error: com.orientechnologies.orient.server.distributed.ODistributedException: Error on execution distributed COMMAND

Error: com.orientechnologies.orient.core.index.OIndexException: Error on rebuilding the index for clusters: [sms]

Error: com.orientechnologies.orient.core.storage.ORecordDuplicatedException: Cannot index record #14:1: found duplicated key 'OCompositeKey{keys=[notify, en]}' in index 'sms_keys' previously assigned to the record #14:0 RID=#14:0

orientdb {db=test}> 

[lvca]

Thanks, working on it...

[lvca]

Reproduced with a Java test case.

[testark]

@lvca This is still the case with 2.1.6.

[lvca]

@testark Could you please look at test case https://github.com/orientechnologies/orientdb/blob/ad0e676ffcae25f13e9a67cc58d9a232e6c07fe1/distributed/src/test/java/com/orientechnologies/orient/server/distributed/asynch/AsyncIndexTest.java#L41-L40? It passes with no problems.

[testark]

@lvca In this line

orientdb/distributed/src/test/java/com/orientechnologies/orient/server/distributed/asynch/BareBoneBase1ClientTest.java

Line 26 in ad0e676

return "plocal:" + DB1_DIR + "/databases/" + getDatabaseName();

I see plocal. I am using remote so, believe me this is still the case.

[lvca]

Created new test case (e2b40ee) with 3 servers and remote and pass...

[testark]

The test case deals with the document API. I'm using the Graph API.

[lvca]

You're right, I was able to reproduce it with 3 nodes, async replication through remote protocol call and graph API that always start a distributed transaction. Working to the fix.

[testark]

@lvca See? :-) I was not trying to be mean or something, just reporting because it is still indeed the case. Glad you can work on that.

[lvca]

Fixed in 2.1.x