Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception details to some logging that lost stack traces. #9862

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,7 @@ public <T> T baseNetworkOperation(
.debug(
this,
"Redirecting the request from server '%s' to the server '%s' because %s",
e,
e.getFromServer(),
e.toString(),
e.getMessage());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,7 @@ private void updateViews(ODatabaseDocumentInternal db) {
// When the run is finished schedule the next run.
schedule();
} catch (Exception e) {
OLogManager.instance().warn(this, "Failed to update views");
e.printStackTrace();
OLogManager.instance().warn(this, "Failed to update views", e);
}
}

Expand Down Expand Up @@ -424,7 +423,8 @@ private List<OIndex> createNewIndexesForView(
}
return result;
} catch (Exception e) {
e.printStackTrace();
OLogManager.instance()
.warn(this, "Failed to create new indexes for view %s", e, view.getName());
return null;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ public static boolean sendResponseBack(
sender,
OUT,
"Error on sending response '%s' back (reqId=%s err=%s)",
e,
response,
iRequestId,
e.toString());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1663,6 +1663,7 @@ protected void installNewDatabasesFromCluster() {
null,
DIRECTION.IN,
"Error on installing database '%s' on local node (error=%s)",
e,
databaseName,
e.toString());
}
Expand Down