Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard database create to avoid partially initialised storage being created #9951

Closed
wants to merge 1 commit into from
Closed

Guard database create to avoid partially initialised storage being created #9951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/com/orientechnologies/orient/core/db/OrientDBEmbedded.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ protected String buildName(String name) {
return basePath + "/" + name;
}

public void create(String name, String user, String password, ODatabaseType type) {
public final void create(String name, String user, String password, ODatabaseType type) {
create(name, user, password, type, null);
}

Expand Down
9 changes: 9 additions & 0 deletions distributed/src/main/java/com/orientechnologies/orient/core/db/OrientDBDistributed.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@ public synchronized OHazelcastPlugin getPlugin() {
return plugin;
}

@Override
public void create(
String name, String user, String password, ODatabaseType type, OrientDBConfig config) {
if (isDistributedEnabled() && (plugin == null)) {
throw new OOfflineNodeException("Distributed plugin is not active");
}
super.create(name, user, password, type, config);
}

protected OSharedContext createSharedContext(OAbstractPaginatedStorage storage) {
if (OSystemDatabase.SYSTEM_DB_NAME.equals(storage.getName())
|| getPlugin() == null
Expand Down