Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrientJS 3.0: Error when using null params #335

Closed
big213 opened this issue Sep 18, 2018 · 4 comments
Closed

OrientJS 3.0: Error when using null params #335

big213 opened this issue Sep 18, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@big213
Copy link

big213 commented Sep 18, 2018

OrientJS Version: 3.0.0-beta3
OrientDB Version: 3.0.7

Steps to reproduce error:
INSERT INTO V SET foo = null
session.query("SELECT FROM #1:0 WHERE foo = :foo", { params: { foo: null } })

Results in this error:
Unhandled rejection TypeError: err.isTokenException is not a function

@wolf4ood wolf4ood self-assigned this Sep 18, 2018
@wolf4ood wolf4ood added the bug label Sep 18, 2018
wolf4ood added a commit that referenced this issue Sep 18, 2018
@wolf4ood
Copy link
Member

Hi @big213

i've just pushed a fix. It will be available on the next release

Thanks

@wolf4ood wolf4ood added this to the 3.0 milestone Sep 18, 2018
@big213
Copy link
Author

big213 commented Oct 1, 2018

Hi @wolf4ood

OrientDB 3.0.8 just rolled out recently, and it seems to be working well so far. However, null params as described in this issue are still not working. In fact, it doesn't throw any error anymore, the query just doesn't return. I guess it is not a huge isssue, I just switched the param to '' for now, but any chance you could push the fix to npm so I can test it?

@wolf4ood
Copy link
Member

wolf4ood commented Oct 1, 2018

Hi @big213

i've published orientjs-3.0.0 let me know if it is ok

Thanks

@big213
Copy link
Author

big213 commented Oct 4, 2018

@wolf4ood All good now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants