Skip to content

#141: Force BigDecimal serialization in non-scientific notation #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

#141: Force BigDecimal serialization in non-scientific notation #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../src/main/java/au/com/origin/snapshots/jackson/serializers/JacksonSnapshotSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import au.com.origin.snapshots.serializers.SnapshotSerializer;
import com.fasterxml.jackson.annotation.JsonAutoDetect;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.core.PrettyPrinter;
import com.fasterxml.jackson.core.util.DefaultIndenter;
import com.fasterxml.jackson.core.util.DefaultPrettyPrinter;
Expand Down Expand Up @@ -45,6 +46,7 @@ public DefaultPrettyPrinter withSeparators(Separators separators) {
{
this.enable(SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS);
this.enable(SerializationFeature.WRITE_DATES_WITH_ZONE_ID);
this.enable(JsonGenerator.Feature.WRITE_BIGDECIMAL_AS_PLAIN);
this.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS);
this.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
this.setSerializationInclusion(JsonInclude.Include.NON_NULL);
Expand Down
6 changes: 6 additions & 0 deletions .../test/java/au/com/origin/snapshots/jackson/serializers/JacksonSnapshotSerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import au.com.origin.snapshots.config.SnapshotConfig;
import au.com.origin.snapshots.serializers.SerializerType;
import au.com.origin.snapshots.serializers.SnapshotSerializer;

import java.math.BigDecimal;
import java.time.Instant;
import java.time.LocalDate;
import java.time.LocalDateTime;
Expand Down Expand Up @@ -112,6 +114,10 @@ private final class TypeDummy {
private final short aShort = 32767;
private final int anInt = 2147483647;
private final long aLong = 9223372036854775807L;
/**
* Note: Stripping trailing zeroes is required to force {@link BigDecimal#toString()} to use scientific notation.
*/
private final BigDecimal aBigDecimal = BigDecimal.valueOf(100).stripTrailingZeros();
private final float aFloat = 0.1234567F;
private final double aDouble = 1.123456789123456D;
private final boolean aBoolean = true;
Expand Down
1 change: 1 addition & 0 deletions ...com/origin/snapshots/jackson/serializers/__snapshots__/JacksonSnapshotSerializerTest.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ au.com.origin.snapshots.jackson.serializers.JacksonSnapshotSerializerTest.should
"aShort": 32767,
"anInt": 2147483647,
"aLong": 9223372036854775807,
"aBigDecimal": 100,
"aFloat": 0.1234567,
"aDouble": 1.123456789123456,
"aBoolean": true,
Expand Down