feat: enable automatic style creation for wms layers' getLegendGraphic #1578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes to fix #1560 . Introduces two properties of a WMS layer:
Where
hasThemeLegend
is necessary for "auto" style creation for WMS layers with a theme legend (to extendedLegend) andlegendParams
is more or less what @steff-o suggested in the related issue.Both properties are ignored if a
style
property also exists for the given WMS layer.The default "scale" for the getLegendGraphic call (there needs to be a scale for scale dependant styles) is the largest scale of the configured map (because typically theme layers have more visible classes at a larger scale than at a smaller scale if scale dependant) however that value is overriden if
scale
is given as alegendParam
.The possibility exists to make
hasThemeLegend
part of thelegendParams
object but it's slightly easier to merely define thehasThemeLegend
property rather than it as part of an object if no special legendParams as per getLegendGraphic() are to be employed.