Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only activate buttons on first level when expanding #1735

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix: only activate buttons on first level when expanding #1735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/ui/collapse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@ export default function Collapse(options = {}) {

// Set tabindex for all buttons to include or exclude in taborder depending on if expanded or not
const setTabIndex = function setTabIndex(idx) {
// Skips the last button since it's slidenav and should be excluded from tab order
for (let i = 0; i < containerEl.getElementsByTagName('button').length - 1; i += 1) {
containerEl.getElementsByTagName('button')[i].tabIndex = idx;
for (let i = 0; i < containerEl.getElementsByTagName('button').length; i += 1) {
// Checks if the button is a direct child of the opened group and not a grandchild which shouldn't be activated until that group is opened
if (containerEl.id === containerEl.getElementsByTagName('button')[i].closest('.collapse-container').id) {
containerEl.getElementsByTagName('button')[i].tabIndex = idx;
}
}
};

Expand Down