Fix map name parsing in permalink store getState() function #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it 100% certain that the map name contains '.json'? What if someone decides to use .geojson or .txt or something? Perhaps it would be safer to split at the last occurence of '.'? Not asking you to change this, just raising the question. |
|
Sure, why not |
This commit refactors permalinkStore.js to extract the map name without the .json extension. The code now uses the lastIndexOf method to find the last occurrence of the '.' character and extracts the substring before it. This improves the readability and maintainability of the code.
|
I don't think this works with inline configuration. Related to this issue #1927 Nevermind, I think I mixed things up. This is reading from mapstate-json not config-json, right? |
Is there (still?) an issue? |
|
If there is a problem after #1927 has been fixed then I'll open a new issue. I think this should be ok to merge. |
tonnyandersson
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2014