Provide IndexMut for Vector<T: Clone> (Issue #30) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilensAngelusNex
changed the title
|
Thanks for your contribution! Looking at travis, you need to do a |
orium
reviewed
Sep 12, 2018
src/vector/mod.rs
Outdated
| @@ -444,6 +464,25 @@ impl<T> Vector<T> { | |||
| } | |||
| } | |||
|
|
|||
| impl<T: Clone> Vector<T> { | |||
| /// Gets a mutable reference to an element. If the element is shared, this Vector will be cloned. | |||
| /// Returns **None** if and only if the given **index** is out of range. | |||
There was a problem hiding this comment.
backtick None and index instead of bold
src/vector/mod.rs
Outdated
| @@ -444,6 +464,25 @@ impl<T> Vector<T> { | |||
| } | |||
| } | |||
|
|
|||
| impl<T: Clone> Vector<T> { | |||
| /// Gets a mutable reference to an element. If the element is shared, this Vector will be cloned. | |||
There was a problem hiding this comment.
I think it is best to say "If the element is shared it will be cloned.". It is true for all mutable operations that part of the vector will be cloned.
src/vector/test.rs
Outdated
| v2[4] = String::from("cloning"); | ||
| v2[5].make_ascii_uppercase(); | ||
|
|
||
| for i in 0..v1.len() { |
There was a problem hiding this comment.
Instead of the loop we can just
assert_eq!(v1, expected1);
assert_eq!(v2, expected2);There was a problem hiding this comment.
I was looping through because the vectors are not actually the same type. I'll change the implementation for the PartialEq and PartialOrd so that this does work.
…Ord|Eq]<U> and make small changes to comments
|
Merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's some work towards #30. I don't think its possible to implement for Vector<T: !Clone>.
I'm pretty new to Rust, so any constructive criticism would be appreciated.