Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Install tests #1557

Merged
merged 3 commits into from
Jun 27, 2019

Conversation

KyleFromKitware
Copy link
Collaborator

@KyleFromKitware KyleFromKitware commented Jun 27, 2019

Fixes #1550

@germasch
Copy link
Contributor

@KyleFromKitware

In terms of the error you're probably debugging right now (the CI failure), I think I've seen that before, and I think it's due to not running the test with mpiexec:

Running ctest -VV on my macbook:

560: 1: Test command:/Users/kai/build/ADIOS2/build/Testing/adios2/install/cmake/C/adios_c_test

With most installations, MPI programs can just be run directly, but sometimes OpenMPI needs help from mpiexec to find its dynamic libs.

Fixtures were initially not used because Adios supports CMake 3.6,
which did not yet have fixtures (they were introduced in 3.7.)
However, adding the fixtures can be done in a backwards compatible
manner without affecting pre-3.7 builds. Add test fixtures to ensure
that Install.Setup always gets run before the other Install tests, even
if it's not specified in the CTest -R regex. (Note that we are still
using the DEPENDS property in addition to FIXTURES_REQUIRED in order
to support 3.6.)
@chuckatkins chuckatkins merged commit ffac0fe into ornladios:master Jun 27, 2019
chuckatkins pushed a commit that referenced this pull request Jun 28, 2019
  Use CTest fixtures in Install tests
  Use MPI in C install test
  Re-enable Install tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install tests breaks with mpi
3 participants