Changes to BP memory management #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this fix the iotest behaves as expected now |
pnorbert
approved these changes
Jan 8, 2020
williamfgc
force-pushed
the
bp_mem
branch
3 times, most recently
from
cb857ae to
00fc136
Compare
Change BP4 memory resize function Reset Engine smart pointer at Close Deallocate explicitly at Close (might not be needed)
Remove resetting engine smart ptr Remove eliminating buffer manually in BP4
Added BP3 test and simplified test naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change BP4 memory resize function
Reset Engine smart pointer at Close
Deallocate explicitly at Close (might not be needed)
Might be related to #1891