core: Simplify IO variable and attribute storage #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the implementation is common to all `Attribute<T>`. Move it to `AttributeBase` and use virtual dispatch to get the `T`-specific part.
Replace the per-type attribute map storing `Attribute<T>` with a single map storing `unique_ptr<AttributeBase>` and downcast as needed.
Replace the per-type variable map storing `Variable<T>` with a single map storing `unique_ptr<VariableBase>` and downcast as needed.
Replace the two-layer map and intermediate index with one direct map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten IO variable and attribute storage maps. Replace each two-layer map (and intermediate index) with one direct map. Map directly from the variable name (or attribute name) to the corresponding
Variable<T>(orAttribute<T>) instance. Avoid using per-type maps by mapping tounique_ptr<VariableBase>(orunique_ptr<AttributeBase>) and statically downcast as needed.This removes several uses of
ADIOS2_FOREACH_*macros and likely enables removal of many more in future work.