Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Wall in Fortran source files #2815

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Aug 5, 2021

Part 3 of: #2766

Followup of https://github.com/ornladios/ADIOS2/pull/2755/files

Notes from this PR:

  • Enables and enforces -Wall (or its corresponding in all the builds using gfortram and ifc.
  • Resolves resulting warnings thought fortran source code.
  • Wall (or its corresponding) its disabled on PGI and XL compiler.

@vicentebolea vicentebolea force-pushed the enable-wall-fortran branch 4 times, most recently from d53d2fa to c0b2706 Compare August 5, 2021 23:26
@vicentebolea vicentebolea changed the title Draft: Enable Wall in Fortran source files Enable Wall in Fortran source files Aug 6, 2021
Copy link
Collaborator Author

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuckatkins I have done a self-review and passed. Could you checkout this branch?

This commit removes multiple unused variables and makes explicit
multiple integer/real casts.

- Removes several trailing whitespaces

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
@chuckatkins chuckatkins merged commit 8cb8336 into ornladios:master Sep 7, 2021
@vicentebolea vicentebolea deleted the enable-wall-fortran branch September 7, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants