Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] HDF5Mixer: size_t #2864

Closed
wants to merge 1 commit into from
Closed

[Draft] HDF5Mixer: size_t #2864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions source/adios2/engine/mixer/HDFMixerWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ void HDFVDSWriter::Init(const std::string &name)
}

void HDFVDSWriter::GetVarInfo(const VariableBase &var,
std::vector<hsize_t> &dimsf, int nDims,
std::vector<hsize_t> &start,
std::vector<hsize_t> &count,
std::vector<hsize_t> &one)
std::vector<size_t> &dimsf, int nDims,
std::vector<size_t> &start,
std::vector<size_t> &count,
std::vector<size_t> &one)
{ // interop::HDF5Common summaryFile(true);
// std::vector<hsize_t> dimsf, start, one, count;
// std::vector<size_t> dimsf, start, one, count;
// int nDims = std::max(var.m_Shape.size(), var.m_Count.size());

for (int i = 0; i < nDims; i++)
Expand Down Expand Up @@ -124,7 +124,7 @@ void HDFVDSWriter::AddVar(const VariableBase &var, hid_t h5Type)
size_t all_counts[m_NumSubFiles][nDims];

//
std::vector<hsize_t> dimsf, start, one, count;
std::vector<size_t> dimsf, start, one, count;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this is likely problematic, since those are used in actual HDF5 API calls below.

Probably needs a copy later on instead.

GetVarInfo(var, dimsf, nDims, start, count, one);
//

Expand All @@ -142,7 +142,7 @@ void HDFVDSWriter::AddVar(const VariableBase &var, hid_t h5Type)
space = H5Screate_simple(nDims, dimsf.data(), NULL);
// summaryFile.Init(fileName.c_str(), MPI_COMM_SELF, true);

hsize_t currCount[nDims], currStart[nDims];
size_t currCount[nDims], currStart[nDims];
// std::string subfileVarName="TimeStep0/"+var.m_Name; // need full
// path? NEED TO GET the RIGHT SUBFILE VAR NAME RELATED to TIMESTEP!!
std::string subfileVarName;
Expand Down
6 changes: 3 additions & 3 deletions source/adios2/engine/mixer/HDFMixerWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ class HDFVDSWriter
int m_Rank;

private:
void GetVarInfo(const VariableBase &var, std::vector<hsize_t> &dimsf,
int nDim, std::vector<hsize_t> &start,
std::vector<hsize_t> &count, std::vector<hsize_t> &one);
void GetVarInfo(const VariableBase &var, std::vector<size_t> &dimsf,
int nDim, std::vector<size_t> &start,
std::vector<size_t> &count, std::vector<size_t> &one);

int m_NumSubFiles;
std::string m_FileName;
Expand Down