Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the virtual NULL engine from the C++/C/Python API... #3126

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Removed the virtual NULL engine from the C++/C/Python API... #3126

merged 1 commit into from
Mar 24, 2022

Conversation

pnorbert
Copy link
Contributor 

Renamed NullCoreWriter to NullWriter. 
Added a NullReader engine but this is still useless. 
"Null" and "NullCore" names both will use these new class. 
Updated docs on Null engine.

@pnorbert
Removed the virtual NULL engine from the C++/C/Python API. Renamed Nu…
624750d 
…llCoreWriter to NullWriter. Added a NullReader engine but this is still useless. "Null" and "NullCore" names both will use these new class. Updated docs on Null engine.
@pnorbert pnorbert added this to the ADIOS v2.8.0 milestone Mar 23, 2022
@pnorbert pnorbert merged commit 2bedf5c into ornladios:release_28 Mar 24, 2022
@pnorbert pnorbert deleted the nullengine branch March 24, 2022 13:43
chuckatkins pushed a commit that referenced this pull request Mar 24, 2022
@pnorbert
Merge pull request #3126 from pnorbert/nullengine
e07b74a 
Removed the virtual NULL engine from the C++/C/Python API...
@chuckatkins chuckatkins mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckatkins chuckatkins Awaiting requested review from chuckatkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADIOS v2.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@pnorbert