Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug BP5 Get for chunks in an ND array #3133

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

anagainaru
Copy link
Contributor

The Get function in BP5 was only capable of reading continuous buffers and was failing tests when reading chunks within the array.

With the current fix the only pattern supported is

if( inIsRowMajor && outIsRowMajor && (inIsLittleEndian == outIsLittleEndian))

but can be easily extended if we think there will be other read patterns with GPU buffer.

I added a test for different read patterns for 2D arrays for GPU buffers for when the CI will include them.

@anagainaru anagainaru requested a review from eisenhauer March 25, 2022 04:28
@anagainaru
Copy link
Contributor Author

@chuckatkins For some reason I cannot create the pull request for release_28 and it's too late to figure it out. I will take care of this in the morning, but I wanted to push it so Greg has time to review it before I wake up.

@chuckatkins chuckatkins changed the base branch from master to release_28 March 25, 2022 06:02
@chuckatkins chuckatkins added this to the ADIOS v2.8.0 milestone Mar 25, 2022
@chuckatkins chuckatkins added bug api:CUDA CUDA API related labels Mar 25, 2022
@chuckatkins
Copy link
Contributor

rebased and re-targeted onto release_28

Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@anagainaru
Copy link
Contributor Author

Not sure why the readthedocs is not passing, should I trigger the testing again?

@eisenhauer
Copy link
Member

It looks like Chuck had several 2am commits to PR #3134 trying to fix readthedocs and that he hasn't succeeded yet. I'd guess that when he gets it fixed, he'll ask for other pending PRs to be rebased and pushed again. So you can probably just sit tight for a while...

@chuckatkins
Copy link
Contributor

Is this good to go?

@anagainaru anagainaru merged commit 3641ced into ornladios:release_28 Mar 25, 2022
chuckatkins pushed a commit that referenced this pull request Mar 29, 2022
Bug BP5 Get for chunks in an ND array
@anagainaru anagainaru deleted the cuda-bug-bp5 branch March 2, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:CUDA CUDA API related bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants