-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug BP5 Get for chunks in an ND array #3133
Conversation
@chuckatkins For some reason I cannot create the pull request for |
a058e08
to
b6ced70
Compare
rebased and re-targeted onto release_28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Not sure why the readthedocs is not passing, should I trigger the testing again? |
It looks like Chuck had several 2am commits to PR #3134 trying to fix readthedocs and that he hasn't succeeded yet. I'd guess that when he gets it fixed, he'll ask for other pending PRs to be rebased and pushed again. So you can probably just sit tight for a while... |
b6ced70
to
e6a8f01
Compare
Is this good to go? |
Bug BP5 Get for chunks in an ND array
The
Get
function inBP5
was only capable of reading continuous buffers and was failing tests when reading chunks within the array.With the current fix the only pattern supported is
but can be easily extended if we think there will be other read patterns with GPU buffer.
I added a test for different read patterns for 2D arrays for GPU buffers for when the CI will include them.