-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the buffer copy logic outside operators #3514
Merged
pnorbert
merged 6 commits into
ornladios:release_29
from
anagainaru:operators-on-gpu-buffers
Mar 2, 2023
Merged
Move the buffer copy logic outside operators #3514
pnorbert
merged 6 commits into
ornladios:release_29
from
anagainaru:operators-on-gpu-buffers
Mar 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
force-pushed
the
operators-on-gpu-buffers
branch
from
March 1, 2023 14:26
8d47bdd
to
8e6b978
Compare
@JieyangChen7 I use 1024 as the threshold for when to apply MGARD based on my testing on Summit but you might have a better idea of what value to use. |
anagainaru
force-pushed
the
operators-on-gpu-buffers
branch
from
March 1, 2023 15:02
8e6b978
to
36e93b6
Compare
anagainaru
changed the title
[WIP] Move the buffer copy logic outside operators
Move the buffer copy logic outside operators
Mar 1, 2023
anagainaru
force-pushed
the
operators-on-gpu-buffers
branch
from
March 1, 2023 15:51
49bf5a7
to
049732f
Compare
@anagainaru I think 1e6 might be a safer choice based on my experience. |
pnorbert
previously approved these changes
Mar 1, 2023
williamfgc
previously approved these changes
Mar 1, 2023
anagainaru
dismissed stale reviews from williamfgc and pnorbert
March 2, 2023 13:08
The base branch was changed.
anagainaru
force-pushed
the
operators-on-gpu-buffers
branch
from
March 2, 2023 13:25
049732f
to
7e7ffcb
Compare
pnorbert
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an operator (direct or inverse) is not applied (due to a threshold or some other reason) the
Operate
orDecompress
functions are now returning 0 and are not responsible with copying the data to the ADIOS2 internal buffers.This allows ADIOS2 to use the appropriate function for copying the data (taking into consideration the memory space).
Operators that use this: Blosc, MGARD, MGARDPlus
Testing Adding test for MGARD with small GPU buffers.
Note: the original code inside operators was using
memcpy
so I am simply moving the logic outside (I am not checking for reverse endian)Adding to #3465 to skip copy for blocks with 0 elements