Fix bug when writing null blocks #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lizdulac <lizadulac@gmail.com> Co-authored-by: Norbert Podhorszki <pnorbert@ornl.gov>
vicentebolea
approved these changes
Mar 17, 2023
lizdulac
approved these changes
Mar 17, 2023
|
@anagainaru feel free to merge when ready |
vicentebolea
pushed a commit
that referenced
this pull request
Mar 20, 2023
Fix bug when writing null blocks
This was referenced Mar 30, 2023
|
Thank you so much @anagainaru , will try again! |
|
@anagainaru should we add a test for this in ADIOS2? (Zero writers and zero writers w/ compressions.) |
|
@anagainaru ping on test coverage? :) #3792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a fix for WarpX where processes write different number of blocks.
Related to PR #3465 and issue #3460
Note: This only affects BP4