Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellcheck: add shellcheck ci check #3582

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Apr 7, 2023

This PR adds shellcheck CI check for shell scripts in the scripts folder.

This will not affect existing shell scripts since "cleaning" them can break them and we cannot test all of them in detail.

@anagainaru
Copy link
Contributor

Good idea, I will re-base my PR once you merge this one

@vicentebolea vicentebolea force-pushed the add-shellcheck-ci branch 4 times, most recently from 508ede8 to 4a1612b Compare April 7, 2023 22:21
@vicentebolea vicentebolea marked this pull request as ready for review April 7, 2023 22:21
Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert but it looks good to me

@vicentebolea vicentebolea merged commit 0419843 into ornladios:master Apr 8, 2023
@vicentebolea vicentebolea deleted the add-shellcheck-ci branch April 8, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants