Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci,olcf,crusher: enable Crusher CI #3620

Merged
merged 1 commit into from
May 25, 2023
Merged

ci,olcf,crusher: enable Crusher CI #3620

merged 1 commit into from
May 25, 2023

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented May 12, 2023 •
edited
Loading

fixes: #3597
fixes: #3600

This PR adds the following Crusher builds:

  • Crusher Kokkos_HIP (SST libfabric)
  • Crusher Cray Compiler (SST libfabric)

The builds are accessible from the Github PR page and it is shown as one more check:

Screenshot from 2023-05-17 21-09-09

Builds are here: https://code.ornl.gov/ecpcitest/adios2/-/pipelines

@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch 11 times, most recently from f18918f to ceee37b Compare May 17, 2023 23:58
@vicentebolea vicentebolea marked this pull request as ready for review May 18, 2023 00:04
@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch 3 times, most recently from 9a8477e to b55634a Compare May 18, 2023 01:00
@vicentebolea vicentebolea self-assigned this May 18, 2023
@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch from b55634a to b2f0215 Compare May 18, 2023 01:34
@vicentebolea vicentebolea changed the title ci,olcf,crusher: enable Crusher CI Draft: ci,olcf,crusher: enable Crusher CI May 18, 2023
@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch 11 times, most recently from db3189c to b83dea9 Compare May 22, 2023 18:30
@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch 5 times, most recently from 08df075 to f248815 Compare May 23, 2023 02:31
@vicentebolea vicentebolea changed the title Draft: ci,olcf,crusher: enable Crusher CI ci,olcf,crusher: enable Crusher CI May 23, 2023
@vicentebolea
Copy link
Collaborator Author

Ready for review @scottwittenburg

@vicentebolea vicentebolea changed the title ci,olcf,crusher: enable Crusher CI WIP: ci,olcf,crusher: enable Crusher CI May 23, 2023
@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch 3 times, most recently from 9aea227 to 31cc1f5 Compare May 23, 2023 22:02
@vicentebolea vicentebolea changed the title WIP: ci,olcf,crusher: enable Crusher CI ci,olcf,crusher: enable Crusher CI May 23, 2023
@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch from 31cc1f5 to db40ecc Compare May 23, 2023 22:30
@vicentebolea
Copy link
Collaborator Author

@scottwittenburg I Think that this PR is in a good state for the review.

@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch 3 times, most recently from 4b92786 to eb6c6f0 Compare May 24, 2023 23:15
@vicentebolea
Copy link
Collaborator Author

@scottwittenburg I addressed the points that we discussed, please re-review

@vicentebolea vicentebolea force-pushed the add-olcf-crusher-ci branch from eb6c6f0 to e095189 Compare May 25, 2023 21:07
scottwittenburg
scottwittenburg approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@scottwittenburg scottwittenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks good to me. Thanks for helping me understand all the changes yesterday!

.gitlab/config/generate_pipelines.py Show resolved Hide resolved
.gitlab/gitlab-ci-crusher.yml Show resolved Hide resolved
scripts/ci/gitlab-ci/setup-vars.sh Show resolved Hide resolved
@vicentebolea
Copy link
Collaborator Author

Thanks @scottwittenburg for the review 🎉

@vicentebolea vicentebolea enabled auto-merge May 25, 2023 22:00
@vicentebolea vicentebolea disabled auto-merge May 25, 2023 22:17
@vicentebolea vicentebolea merged commit 1e5ebec into ornladios:master May 25, 2023
@vicentebolea vicentebolea deleted the add-olcf-crusher-ci branch May 25, 2023 22:18
@vicentebolea vicentebolea mentioned this pull request May 29, 2023
Merged
@BrewTestBot BrewTestBot mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottwittenburg scottwittenburg scottwittenburg approved these changes

Assignees

@vicentebolea vicentebolea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Crusher Cray compiler build Create Crusher Kokkos_HIP build
2 participants
@vicentebolea @scottwittenburg