-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version constants plus functions to retrieve list of ... #3676
Conversation
@vicentebolea What went wrong here in the Ascent test? The Install.cmake.* tests failed but it's not clear what was wrong and what could be done about it. |
Those tests failures are unrelated to this change. They have something to
do with the ascent DFS. I am disabling them for a little while.
…On Mon, Jun 26, 2023, 17:37 pnorbert ***@***.***> wrote:
@vicentebolea <https://github.com/vicentebolea> What went wrong here in
the Ascent test? The Install.cmake.* tests failed but it's not clear what
was wrong and what could be done about it.
—
Reply to this email directly, view it on GitHub
<#3676 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHFOFXGBCS6CO7GNQMUCD3XNITLVANCNFSM6AAAAAAZTHRCMM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the GPU backends and it looks good:
Available features = 4: MPI, Fortran, Python, Kokkos (Host, CUDA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I am not too strong on the const char/char const, I can see that you are trying to make the char const *const **
easier to read. I can see both trade-offs, I am happy both ways :)
Clicking update branch with rebase should get rid of the failed tests in Ascent. |
7d6e0d0
to
29b9b68
Compare
@pnorbert I made the edit as per your request, I added a unit test just to be complete and made a few changes. |
…s, operators and features. This is a C header but it's part of the core library
9316f95
to
2e3f2d8
Compare
@eisenhauer Norbert needs this in the incoming 2.9.1 release, he asked me to finish the task instead of him as he is not available at the moment. I wonder if you could review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me...
Looks good to me, just please make sure a C code can still use this, nothing breaks with expecting C++. |
2e3f2d8
to
6c4c723
Compare
Version constants plus functions to retrieve list of ... (cherry picked from commit 490bed5)
* release_29: Bump version to v2.9.1 Merge pull request #3676 from pnorbert/c_version2 Merge pull request #3697 from ornladios/dependabot/pip/docs/cryptography-41.0.2 Merge pull request #3698 from vicentebolea/add-gitattribute-file Merge pull request #3704 from ornladios/dependabot/pip/docs/pygments-2.15.0 Merge pull request #3712 from ornladios/dependabot/pip/docs/certifi-2023.7.22 Merge pull request #3687 from dmitry-ganyushin/i3646-mult-macos Merge pull request #3699 from vicentebolea/revert-normalize-eol Merge pull request #3689 from vicentebolea/fix-evpath-modules
available engines, operators and features. This is a C header but it's part of the core library.
Fixes #3630
C example:
Build C example: