Fix: std::min w/ windows.h in C-Blosc2 #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed |
Explictly specialize to avoid macro resolution when windows.h is included. What a world to live in.
ax3l
force-pushed
the
fix-blosc2-windows-min
branch
from
7e88e23
to
6277f97
Compare
vicentebolea
pushed a commit
that referenced
this pull request
Jul 3, 2023
Fix: std::min w/ windows.h in C-Blosc2
|
Backported to master |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explictly specialize to avoid macro resolution when windows.h is included. What a world to live in.
X-ref: #3680 (comment)
@vicentebolea did I do this right? This PR should go in
masterandrelease_29alike.