Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SelectionType values #3784

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Remove unused SelectionType values #3784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b49a36
Remove unused SelectionType values
eisenhauer Aug 28, 2023
0ba1e12
Merge branch 'master' into Cleanup
eisenhauer Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions source/adios2/common/ADIOSTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,8 @@ std::string ToString(SelectionType value)
{
case SelectionType::BoundingBox:
return "SelectionType::BoundingBox";
case SelectionType::Points:
return "SelectionType::Points";
case SelectionType::WriteBlock:
return "SelectionType::WriteBlock";
case SelectionType::Auto:
return "SelectionType::Auto";
default:
return "ToString: Unknown SelectionType";
}
Expand Down
2 changes: 0 additions & 2 deletions source/adios2/common/ADIOSTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,8 @@ enum class SelectionType
{
BoundingBox, ///< Contiguous block of data defined by offsets and counts
/// per dimension
Points, ///< List of individual points
WriteBlock, ///< Selection of an individual block written by a writer
/// process
Auto ///< Let the engine decide what to return
};

// Data types.
Expand Down
2 changes: 0 additions & 2 deletions testing/adios2/interface/TestADIOSInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ TEST_F(ADIOS2_CXX11_API, ToString)
EXPECT_EQ(ToString(adios2::TimeUnit::Hours), "TimeUnit::Hours");

EXPECT_EQ(ToString(adios2::SelectionType::BoundingBox), "SelectionType::BoundingBox");
EXPECT_EQ(ToString(adios2::SelectionType::Points), "SelectionType::Points");
EXPECT_EQ(ToString(adios2::SelectionType::WriteBlock), "SelectionType::WriteBlock");
EXPECT_EQ(ToString(adios2::SelectionType::Auto), "SelectionType::Auto");
}

TEST_F(ADIOS2_CXX11_API, APIToString)
Expand Down