Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the ADIOS_USE_{} variable names to use ADIOS2 #3807

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix the ADIOS_USE_{} variable names to use ADIOS2 #3807

merged 1 commit into from
Sep 13, 2023

Conversation

anagainaru
Copy link
Contributor

Randomly found this bug when testing the query code.

vicentebolea
vicentebolea previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 haha

Good catch!

@vicentebolea
Copy link
Collaborator

In the same topic, there is also a comment which might confuse future devs.

cmake/ADIOSFunctions.cmake:/* CMake Option: ADIOS_USE_${OPT}=OFF */

@vicentebolea
Copy link
Collaborator

And an example

cmake/ADIOSFunctions.cmake:/* CMake Option: ADIOS_USE_${OPT}=OFF */
cmake/DetectOptions.cmake:if(ADIOS_USE_Kokkos AND ADIOS_USE_CUDA)
cmake/DetectOptions.cmake:  message(FATAL_ERROR "ADIOS2_USE_Kokkos is incompatible with ADIOS_USE_CUDA")
examples/hello/README.md:1. datamanReader (to be deprecated, ADIOS_USE_DataMan=ON)
examples/hello/README.md:1. hdf5Writer (-DADIOS_USE_HDF5=ON)

@anagainaru @vicentebolea
Fix the ADIOS_USE_{_} variable names to use ADIOS2
7b0c876 
Co-authored-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
@anagainaru anagainaru changed the title Fix the ADIOS2_USE_{GPU related} variable names Fix the ADIOS_USE_{} variable names to use ADIOS2 Sep 13, 2023
@anagainaru
Copy link
Contributor Author

Done, I added the other places. You'll need to re-approve :)

@anagainaru anagainaru merged commit c2a5faf into ornladios:master Sep 13, 2023
@anagainaru anagainaru deleted the gpu-cmake-bug branch September 13, 2023 18:59
@BrewTestBot BrewTestBot mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentebolea vicentebolea vicentebolea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anagainaru @vicentebolea