Fix usage of DESTDIR for absolute paths #3838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@td-mpcdf thanks for your contribution. Looks good, minor formatting suggestion. |
|
@td-mpcdf your branch for the PR cannot be master. Please move the changes to another branch. |
|
superseded by #3850 |
auto-merge was automatically disabled
October 17, 2023 20:24
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution to issue !3837.
In the
generate-adios2-config.shfile, I added a code path in the case that theCMAKE_INSTALL_PREFIXis an absolute path but does not exist. In this case theDESTDIRis prepended.