Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FindBlosc2 #3910

Closed
wants to merge 2 commits into from
Closed

Remove FindBlosc2 #3910

wants to merge 2 commits into from

Conversation

ax3l
Copy link
Contributor

@ax3l ax3l commented Nov 10, 2023

Going forward, it might be easier if we dump the dependency to 2.10.2+
https://github.com/Blosc/c-blosc2/releases/tag/v2.10.2

Related to #3903

@ax3l ax3l requested a review from vicentebolea as a code owner November 10, 2023 00:40
@ax3l ax3l force-pushed the topic-rm-findblosc2 branch from d8f1a9e to 6e70723 Compare November 10, 2023 00:41
@vicentebolea
Copy link
Collaborator

@ax3l thansk for the contribution, we still support blosc2 >= 2.4 without problems. I think that the issues that you found are due to the fact that blosc2 could not be installed due to depedencies missing and using as a backup this FindBlosc file.

@vicentebolea
Copy link
Collaborator

I rebased on the top of master, there was some unrelated CI failures in master for a two weeks.

@ax3l
Copy link
Contributor Author

ax3l commented Nov 27, 2023

Thanks @vicentebolea

I think that the issues that you found are due to the fact that blosc2 could not be installed due to depedencies missing and using as a backup this FindBlosc file.

I cannot see a c-blosc2 install issue here:
openPMD/openPMD-api#1554

@pnorbert pnorbert force-pushed the topic-rm-findblosc2 branch from 0e20406 to ff698a2 Compare December 7, 2023 13:26
@pnorbert
Copy link
Contributor

pnorbert commented Dec 7, 2023

It doesn't hurt to increase the version requirement for blosc2.

@vicentebolea
Copy link
Collaborator

Note that we might not have an issue with our current FindBlosc2.cmake file. The error that @ax3l have been seeing it seems to be unrelated to this file.

The error that was reported at #3903 seems to be related to the blosc2config.cmake not to be found.

We might not want to arbitrarily drop dependency to older c-blosc2 since dependending on its last release might hinder users that do not have access to older c-blocs2 versions.

@vicentebolea
Copy link
Collaborator

This was already done at #4093. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants