Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip packaging #3960

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add pip packaging #3960

merged 1 commit into from
Dec 15, 2023

Conversation

scottwittenburg
Copy link
Collaborator

Add python packaging so users can pip install adios2. This PR follows general guidance here regarding choice of tooling and practices.

Supersedes #3949

@vicentebolea
Copy link
Collaborator

This is awesome! ill do a review this Monday

@scottwittenburg
Copy link
Collaborator Author

Finally success uploading a package to test.pypi.org!

After moving the PR to a branch on the main repo, I still had repeated failures to push. Some discussion around here suggested removing and re-adding the trusted publisher on the testpypi side, and when I did that, it worked! 🎉

Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work there We are almost there, the idea looks great! As for the comments I know that this is still WIP, I just added some comments.

.github/workflows/pypackaging.yml Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
bindings/Python/CMakeLists.txt Outdated Show resolved Hide resolved
bindings/Python/CMakeLists.txt Outdated Show resolved Hide resolved
cmake/DetectOptions.cmake Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
source/adios2/toolkit/sst/util/CMakeLists.txt Outdated Show resolved Hide resolved
thirdparty/EVPath/CMakeLists.txt Outdated Show resolved Hide resolved
@vicentebolea
Copy link
Collaborator

Another thing to add is the badge at the readme.

@scottwittenburg
Copy link
Collaborator Author

If you download the the wheel or sdist from the artifacts of the latest "Python Packaging" build, you can see that now the version we build (the version in the .tar.gz or .whl file name) matches the version baked into the module.

@scottwittenburg
Copy link
Collaborator Author

Now each wheel undergoes an extra step where it is installed, and a simple test is run against it, e.g. here.

@scottwittenburg scottwittenburg merged commit d650742 into master Dec 15, 2023
39 checks passed
@vicentebolea vicentebolea deleted the add-pip-packaging branch July 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants