-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pip packaging #3960
Add pip packaging #3960
Conversation
This is awesome! ill do a review this Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work there We are almost there, the idea looks great! As for the comments I know that this is still WIP, I just added some comments.
Another thing to add is the badge at the readme. |
51fe381
to
0786486
Compare
If you download the the wheel or sdist from the artifacts of the latest "Python Packaging" build, you can see that now the version we build (the version in the |
cd60c10
to
2614157
Compare
Now each wheel undergoes an extra step where it is installed, and a simple test is run against it, e.g. here. |
2614157
to
0272d85
Compare
0272d85
to
39ff134
Compare
Add python packaging so users can pip install adios2. This PR follows general guidance here regarding choice of tooling and practices.
Supersedes #3949