Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SST ASAN buffer fix #3972

Merged
merged 2 commits into from
Dec 28, 2023
Merged

SST ASAN buffer fix #3972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
344e26f
Release data buffer as well
eisenhauer Dec 28, 2023
2eb7c22
Suppress fewer tests
eisenhauer Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 10 additions & 29 deletions CTestConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,35 +14,16 @@ set(MEMORYCHECK_SUPPRESSIONS_FILE ${CMAKE_SOURCE_DIR}/scripts/dashboard/nightly/

# Ignore tests that are currently failing, remove tests here as they are fixed
list(APPEND CTEST_CUSTOM_MEMCHECK_IGNORE
Staging.TimeoutReader.1x1.CommMin.BP5.SST
Staging.1x1Struct.BP5
Staging.WriteMemorySelectionRead.1x1.CommMin.BP.SST
Staging.1x1.Local2.CommMin.BP.SST
Staging.OnDemandSingle.1x1.CommMin.BP5.SST
Staging.AllToAllDistribution.1x1x3.CommMin.BP5.SST
Staging.RoundRobinDistribution.1x1x3.CommMin.BP5.SST
Staging.1x1.LocalMultiblock.CommMin.BP5.SST
Staging.1x1.SstRUDP.CommMin.BP5.SST
Staging.WriteMemorySelectionRead.1x1.CommMin.BP5.SST
Staging.1x1LockGeometry.CommMin.BP5.SST
Staging.1x1.ForcePreload.CommMin.BP5.SST
Staging.1x1.NoPreload.CommMin.BP5.SST
Staging.DiscardWriter.1x1.CommMin.BP5.SST
Staging.LatestReaderHold.1x1.CommMin.BP5.SST
Staging.LatestReader.1x1.CommMin.BP5.SST
Engine.BP.BPWriteReadAsStreamTestADIOS2.ReaderWriterDefineVariable.BP5.Serial
Staging.ZFPCompression.3x5.CommMin.BP5.SST
Staging.ZFPCompression.1x1.CommMin.BP5.SST
Staging.1x1Joined.CommMin.BP5.SST
Staging.1x1Struct.CommMin.BP5.SST
Staging.1x1.Local2.CommMin.BP5.SST
Staging.1x1VarDestruction.CommMin.BP5.SST
Staging.1x1.ModAttrs.CommMin.BP5.SST
Staging.1x1.Attrs.CommMin.BP5.SST
Staging.1x1.CommMin.BP5.SST
Engine.SST.SstWriteFails.InvalidBeginStep.Serial
remoteServerCleanup
Remote.BPWriteMemorySelectionRead.FileRemote
Remote.BPWriteMemorySelectionRead.GetRemote
Remote.BPWriteReadADIOS2stdio.GetRemote
Remote.BPWriteMemorySelectionRead.GetRemote
Remote.BPWriteMemorySelectionRead.FileRemote
remoteServerCleanup
Engine.SST.SstWriteFails.InvalidBeginStep.Serial
Staging.1x1.Local2.CommMin.BP5.SST
Staging.1x1Struct.CommMin.BP5.SST
Staging.WriteMemorySelectionRead.1x1.CommMin.BP5.SST
Staging.1x1.Local2.CommMin.BP.SST
Staging.WriteMemorySelectionRead.1x1.CommMin.BP.SST
Staging.1x1Struct.BP5
)
1 change: 1 addition & 0 deletions source/adios2/engine/sst/SstWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ void SstWriter::EndStep()
// Free data and metadata blocks here. BlockToFree is the newblock
// value in the enclosing function.
free(BlockToFree->MetaMetaBlocks);
delete BlockToFree->TSInfo->DataBuffer;
delete BlockToFree->TSInfo;
delete BlockToFree;
};
Expand Down
Loading