Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Testing build #4027

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix Windows Testing build #4027

merged 1 commit into from
Feb 20, 2024

Conversation

eisenhauer
Copy link
Member

No description provided.

@eisenhauer
Copy link
Member Author

This was broken when Python is present for the build, which is apparently not the case for our Windows CI.

@vicentebolea
Copy link
Collaborator

@eisenhauer that makes sense, however, I cannot see Python enabled in any of our Windows builds.

@eisenhauer
Copy link
Member Author

@eisenhauer that makes sense, however, I cannot see Python enabled in any of our Windows builds.

It's not, but that's just the explanation for why we didn't know this was broken...

@vicentebolea
Copy link
Collaborator

It's not, but that's just the explanation for why we didn't know this was broken...

I see, how about enabling python to see if this fixes it(or at least move us to an step closer to have python in Win)?

@eisenhauer
Copy link
Member Author

So, I can say that it fixes it in my Windows Visual Studio build (which has python present). We can also change a CI to do this. (But if we're adding CIs, I'd probably prioritize Issue #4025 . We definitely have someone that needs that.)

@eisenhauer eisenhauer merged commit d943ecb into ornladios:master Feb 20, 2024
37 checks passed
@eisenhauer eisenhauer deleted the PyTarget branch February 20, 2024 19:50
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants