Add API call to reset memory selection #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix. Indeed, the selection is sticky, at least, that's how the gray-scott example is using it. It defines the variable and sets the memory selection once, and then this is used for all steps. Never occured to me enable a reset. |
eisenhauer
approved these changes
May 22, 2024
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
May 28, 2024
* Add API to reset memory selection
Merged
vicentebolea
added a commit
that referenced
this pull request
May 29, 2024
* release_210: Bump version to v2.10.1 Kill outdated reference to bindings.Mode.ReadFlattenSteps (#4185) fix: make changes from #4160 abi compat fix: make changes from #4144 abi compat Remove special ReadFlattenSteps Mode, switch to control by writer-sid… (#4160) EVPath 2024-05-27 (45471c87) (#4181) Add API call to reset memory selection (#4169) Typo in the build command inside the documentation (#4166) Merge pull request #4161 from anagainaru/derived-performance Minor docs tweaks (#4153) ReadModeFlatten (#4147) Merge pull request #4142 from vicentebolea/fix-pugixml-dep Fixes for FreeBSD, including upstream (#4138) Deactivate campaign recording by default. Use .adios-campaign/ as directory name. test CI fix (#4177) - based on char signess in installed adios library, use numpy.int8 or numpy.uint8 to read char arrays from BP files - move char as last type in adios type macros, so that unsigned char always becomes uint8_t and signed char becomes int8_t in output (char arrays still become char in output) - add C++ test to write and read char/signed char/unsigned char arrays dill 2024-04-04 (55420dee) (#4136) pugixml: correct target name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently adding support for memory selections to the openPMD-api on openPMD/openPMD-api#1620.
While working on it, I noticed that the selection specified in
Variable<T>::SetMemorySelection(...)sticks to all subsequentPut()calls, without a way to remove the memory selection again.Is it intended that the setting will stick to the Variable or is that a bug? If it is intended, this PR adds a way to remove the setting again. Otherwise, this PR should be discarded and instead, the memory selection should be removed automatically after calling
Put().cc @pnorbert