Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kokkos: support ROCM >=6 #4214

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

vicentebolea
Copy link
Collaborator

Backports #4213

@vicentebolea vicentebolea merged commit d6e61c8 into ornladios:release_210 Jun 28, 2024
39 checks passed
@vicentebolea vicentebolea deleted the enable-rocm6 branch June 28, 2024 15:32
@anagainaru
Copy link
Contributor

I would like to better understand, did rocm 6 change the API on detecting the allocation type? Could you send me a link to the rocm documentation about this change?

I want to test this on Frontier to make sure we can't use something that is the same across all rocm versions before we consider this complete.

@vicentebolea
Copy link
Collaborator Author

Hi @anagainaru welcome back! Good point.

hipPointerAttribute_t API in:

Yep, it would have been nice from the AMD rocm team to put some [[deprecated]] before phasing out the old attribute.

@anagainaru
Copy link
Contributor

Yes you are right, I don't think there is any better way of handling this. I was hoping there would be some other solution to test for the allocation of a buffer but I can't seem to find anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants