Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw dash lines for sunrise and sunset #93

Closed
orontee opened this issue Jul 7, 2024 · 3 comments
Closed

Draw dash lines for sunrise and sunset #93

orontee opened this issue Jul 7, 2024 · 3 comments
Assignees
@orontee
Labels
enhancement New feature or request screenshots Issue implies screenshots update ui
Milestone
Summer 2024 release

Comments

@orontee
Copy link
Owner

orontee commented Jul 7, 2024 •
edited
Loading

Context

Since the sunrise and sunset date times are known through the daily forecasts, one expect to see them on the hourly forecast view.

Analysis

Draw a vertical dash line at the corresponding times.
@orontee orontee added enhancement New feature or request ui labels Jul 7, 2024
@orontee orontee added this to the Next release milestone Jul 7, 2024
@orontee orontee self-assigned this Jul 7, 2024
orontee added a commit that referenced this issue Jul 7, 2024
@orontee
Draw lines for sunrise and sunset
222013b 
Refs: #93
orontee added a commit that referenced this issue Jul 7, 2024
@orontee
Draw lines for sunrise and sunset
2751b2e 
Refs: #93
@orontee
Copy link
Owner Author

orontee commented Jul 7, 2024

93

@orontee orontee closed this as completed Jul 7, 2024
@orontee
Copy link
Owner Author

orontee commented Jul 8, 2024 •
edited
Loading

When there're precipitations, the vertical bar overlaps the histogram. Ugly.

@orontee orontee reopened this Jul 8, 2024
orontee added a commit that referenced this issue Jul 8, 2024
@orontee
Fix sunrise or sunset lines overlapping precipitation histogram
0e9ffcc 
Refs: #93
orontee added a commit that referenced this issue Jul 8, 2024
@orontee
Fix sunrise or sunset lines overlapping precipitation histogram
c6e1f1a 
Refs: #93
@orontee
Copy link
Owner Author

orontee commented Jul 8, 2024

fixed-vertical-lines-overlapping-histogram

@orontee orontee closed this as completed Jul 8, 2024
@orontee orontee added the screenshots Issue implies screenshots update label Jul 8, 2024
This was referenced Aug 3, 2024
Closed
Open
@orontee orontee mentioned this issue Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orontee orontee

Labels
enhancement New feature or request screenshots Issue implies screenshots update ui
Projects
None yet
Milestone
Summer 2024 release
Development

No branches or pull requests
1 participant
@orontee