Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated ReactiveCoca version to ReactiveObjC #300

Closed
wants to merge 7 commits into from

Conversation

DinosaurDad
Copy link

ReactiveCocoa has changed to Swift, so moving ARAnalytics to ReactiveObjC is a better fit. This allows apps that have moved to ReactiveObjC to avoid also including ReactiveCocoa when using the DSL subspec.

@orta
Copy link
Owner

orta commented Jul 17, 2017

Any chance you can run bundle update colored2 ?

@orta
Copy link
Owner

orta commented Jul 17, 2017

That should fix the red

@orta
Copy link
Owner

orta commented Jul 18, 2017

Oh damn, that's a lot of commits - @Matt-ExpeData you don't need to make this go green, that's my responsibility - I was kinda hoping it would just require a quick fix.

@@ -5,7 +5,7 @@ Pod::Spec.new do |s|
s.homepage = 'https://github.com/orta/ARAnalytics'
s.authors = { 'orta' => 'orta.therox@gmail.com', 'Daniel Haight' => "confidence.designed@gmail.com" }
s.source = { :git => 'https://github.com/orta/ARAnalytics.git', :tag => s.version.to_s }
s.ios.deployment_target = "7.0"
s.ios.deployment_target = "8.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a semver breaking change, we'll need to bump the major for the next release

Copy link
Author

@DinosaurDad DinosaurDad Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turned into quite a chain of required changes. I also noted that xctool no longer does builds and instead uses action run-tests, so I needed to do this:

xcodebuild -workspace Example/ARAnalyticsTests.xcworkspace -scheme ARAnalyticsBootstrapiOS -sdk iphonesimulator
xctool -workspace Example/ARAnalyticsTests.xcworkspace -scheme ARAnalyticsBootstrapiOS -sdk iphonesimulator run-tests

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you give me access to this branch, I'll get it green 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got it. I'm also @Matt-ExpeData - the name that shows up depends on which app/machine I use for commits.

@orta
Copy link
Owner

orta commented Jul 21, 2017

Err - oops, do you still have those commits?

@orta
Copy link
Owner

orta commented Jul 21, 2017

I have what I think is a working travis.yml now:

language: objective-c
osx_image: xcode9
env:
  global:
    - LC_CTYPE=en_US.UTF-8
    - LANG=en_US.UTF-8
before_script:
  - echo -e "Host *\n\tStrictHostKeyChecking no\n" >> ~/.ssh/config
  - bundle exec danger
  - cd Example; pod install; cd ..

script:
  - set -o pipefail && xcodebuild -workspace Example/ARAnalyticsTests.xcworkspace -scheme ARAnalyticsBootstrapiOS -configuration Debug test -sdk iphonesimulator -destination platform='iOS Simulator',OS='9.0',name='iPhone 6' CODE_SIGNING_REQUIRED=NO | bundle exec xcpretty

@DinosaurDad
Copy link
Author

I just force pushed. ;)

@orta
Copy link
Owner

orta commented Jul 21, 2017

I recreated this PR from scratch in #302 - will release that as 5.0.0

@orta orta closed this in #302 Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants