-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from deprecated ReactiveCoca version to ReactiveObjC #300
Conversation
Any chance you can run |
That should fix the red |
Oh damn, that's a lot of commits - @Matt-ExpeData you don't need to make this go green, that's my responsibility - I was kinda hoping it would just require a quick fix. |
@@ -5,7 +5,7 @@ Pod::Spec.new do |s| | |||
s.homepage = 'https://github.com/orta/ARAnalytics' | |||
s.authors = { 'orta' => 'orta.therox@gmail.com', 'Daniel Haight' => "confidence.designed@gmail.com" } | |||
s.source = { :git => 'https://github.com/orta/ARAnalytics.git', :tag => s.version.to_s } | |||
s.ios.deployment_target = "7.0" | |||
s.ios.deployment_target = "8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a semver breaking change, we'll need to bump the major for the next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turned into quite a chain of required changes. I also noted that xctool
no longer does builds and instead uses action run-tests
, so I needed to do this:
xcodebuild -workspace Example/ARAnalyticsTests.xcworkspace -scheme ARAnalyticsBootstrapiOS -sdk iphonesimulator
xctool -workspace Example/ARAnalyticsTests.xcworkspace -scheme ARAnalyticsBootstrapiOS -sdk iphonesimulator run-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you give me access to this branch, I'll get it green 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got it. I'm also @Matt-ExpeData - the name that shows up depends on which app/machine I use for commits.
Err - oops, do you still have those commits? |
I have what I think is a working
|
I just force pushed. ;) |
I recreated this PR from scratch in #302 - will release that as 5.0.0 |
ReactiveCocoa has changed to Swift, so moving ARAnalytics to ReactiveObjC is a better fit. This allows apps that have moved to ReactiveObjC to avoid also including ReactiveCocoa when using the DSL subspec.