Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 7.3 Compatibility #36

Closed
ashfurrow opened this issue Mar 23, 2016 · 8 comments
Closed

Xcode 7.3 Compatibility #36

ashfurrow opened this issue Mar 23, 2016 · 8 comments

Comments

@ashfurrow
Copy link
Contributor

As noted in my Eigen PR, Xcode 7.3 doesn't print test results to the debug console like it used to (they're sent to a log file). Snapshots plugin will need to either read that file or (and I think Orta talked to me about this) listen for notifications from Xcode about passed/failed tests.

I'll try to take a stab at this, likely with ashfurrow/second_curtain#40 for good measure.

@orta
Copy link
Owner

orta commented Mar 23, 2016

Probably best to setup a NSFileCoordinator for where-ever the logs come in to, I've wanted to make Snapshots standalone - and this it what it needed to do that. With that there's no need to build into Xcode.

@ashfurrow
Copy link
Contributor Author

👍 Cool, thanks for the guidance!

@ashfurrow
Copy link
Contributor Author

Quick is also looking at something similar, I'll keep an eye on it to see what happens.

@ashfurrow
Copy link
Contributor Author

scan/xcpretty/quick are all having issues with this. I'm not sure what the solution will be, I've looked through the generated log and plist test summaries and neither has the data as we need it. I'm not really qualified to go digging for which NSNotifications to listen to, so I'm going to have to put this aside for now.

@ashfurrow
Copy link
Contributor Author

Loooooks like it might've just been a bug in Nimble: Quick/Nimble#271 I'll keep on top of it.

@raphaelcruzeiro
Copy link

Any news on this? I kinda have a broken CI flow because of this issue (if there's anyway I can help, just let me know).

@ashfurrow
Copy link
Contributor Author

Yes, the problem has been fixed on Nimble, but the solution is causing new problems. Since the fix is in master, we're using it and it has solved this problem for now.

Actually I think we can close this issue now, since it's not a problem with this specific project. Thoughts?

@orta
Copy link
Owner

orta commented Apr 2, 2016

Aye - I think #37 also covers this from the perspective of doing it in snapshots itself.

@orta orta closed this as completed Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants