Xcode 7.3 updates #1353
Xcode 7.3 updates #1353
Conversation
|
By analyzing the blame information on this pull request, we identified @orta to be a potential reviewer |
| @@ -189,7 +189,7 @@ - (void)addArtworksInShow:(PartnerShow *)show atPage:(NSInteger)page toView:(ARA | |||
| { | |||
| __weak typeof(self) wself = self; | |||
| [self getArtworksInShow:show atPage:page success:^(NSArray *artworks) { | |||
| if (!artworks.count > 0) { return; } | |||
| if (artworks.count < 1) { return; } | |||
There was a problem hiding this comment.
Oh, jeez. Can’t this be simplified to count == 0 ?
There was a problem hiding this comment.
Sure can, it's a preference/style thing I guess. I usually go with Swift has an < 1isEmpty that I normally use.
There was a problem hiding this comment.
I like equal comparison, because with < I have to think for a split second whether or not this value could really be a negative value.
There was a problem hiding this comment.
I agree that checking for ‘empty’ is much nicer.
ashfurrow
force-pushed
the
ashfurrow-xcode-7.3-updates
branch
from
cdecd9a
to
92d4c4c
Compare
Generated by 🚫 danger |
|
Looks good, hello future! |
| @@ -26,6 +26,7 @@ upcoming: | |||
| - Fixes cell bottom margin issues. - ash | |||
| - Fix hero unit description not fully showing when spanning multiple lines. - alloy | |||
| - Fix auction related analytics. - orta + alloy | |||
| - Updates for Xcode 7.3. - ash | |||
There was a problem hiding this comment.
Oh, this is not right, 2.4.1 has been submitted to the app store, so this needs to be in a new section.
|
🍏 |
|
Parfait 👍 |
|
@sarahscott @mennenia Be sure to update your Xcodes |
There are some Swift warnings, as discussed that I can look at when we're all moved to Xcode 7.3. When/if this is merged, I'll open an issue.So, this PR moves Eigen to Xcode 7.3 and Swift 2.2. Everyone will need to use Xcode 7.3 after this is merged.
I generally like Xcode 7.3, especially the autocomplete. I will warn that Orta's snapshot plugin won't work because unit tests no longer print to the debugging console (going to try and take a look at this later, I think Orta already had a solution in mind).