Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-like "unique index" for the id column #8

Closed
lvsltz opened this issue Oct 24, 2019 · 2 comments · Fixed by #10
Closed

sql-like "unique index" for the id column #8

lvsltz opened this issue Oct 24, 2019 · 2 comments · Fixed by #10

Comments

@lvsltz
Copy link
Collaborator

lvsltz commented Oct 24, 2019

intracellular_recordings, ic_sweeps, ic_sweep_sequences, ic_runs tables allow insertions of rows with the same id.
I think id should be unique.

MWE:

nwbfile.add_ic_sweep(recordings=[0], id=12)
nwbfile.add_ic_sweep(recordings=[0], id=12)
nwbfile.ic_sweeps.to_dataframe()
@lvsltz lvsltz changed the title sql-like "index unique" for the id column sql-like "unique index" for the id column Oct 24, 2019
@oruebel
Copy link
Owner

oruebel commented Oct 24, 2019

I think id should be unique.

Agreed.

@oruebel oruebel mentioned this issue Oct 24, 2019
Merged
oruebel added a commit that referenced this issue Oct 24, 2019
@oruebel
Fix #8 Enforce that ids are unique in all ICEPhys tables
cb6feb4
@oruebel oruebel mentioned this issue Oct 24, 2019
Merged
@oruebel
Copy link
Owner

oruebel commented Oct 24, 2019

@lvsltz #10 should fix this. This requires the latest version of HDMF as this depends on hdmf-dev/hdmf#186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce that ids are unique in all ICEPhys tables oruebel/ndx-icephys-meta
2 participants
@lvsltz @oruebel