Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(msw): correctly add imports for enum references #1456

Merged
merged 2 commits into from
Jun 14, 2024
Merged

fix(msw): correctly add imports for enum references #1456

merged 2 commits into from
Jun 14, 2024

Conversation

dteske25
Copy link
Contributor

Status

READY

Description

Fixes #1455

Related PRs

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

Based on the example added in #1455, I was able to confirm that the import statement for the enum was being added correctly, and that there were no TS errors.

@melloware melloware added the mock Related to mock generation label Jun 14, 2024
@melloware melloware added this to the 6.31.0 milestone Jun 14, 2024
@melloware
Copy link
Collaborator

Thanks for the PR! LGTM i am letting the build run now.

@dteske25
Copy link
Contributor Author

Thanks for the quick review! I had a good time digging into this!

@melloware melloware merged commit f580f5d into orval-labs:master Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mock Related to mock generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing import for enum with MSW mock generation
2 participants