Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add guide for NextAuth #1730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: add guide for NextAuth #1730

wants to merge 1 commit into from

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 7, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it ❤️

just a few changes, then merge it

4. Select "Server App".
5. Choose a client name, e.g. "NextAuth Example".
6. Scopes `openid` and `offline_access` are preselected. Add `email` and `profile` to the list.
7. Add the redirect URL, for example `http://localhost:3000/api/auth/callback/ory`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
7. Add the redirect URL, for example `http://localhost:3000/api/auth/callback/ory`.
7. Add the redirect URL, for example, `http://localhost:3000/api/auth/callback/ory`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's strange, I had to use http://localhost:3000/auth/callback/ory as the Callback URL. Maybe it's because of the new app router? I'm not sure. Probably should just add both of the URLs to the allowed redirect URLs.

Copy link

argos-ci bot commented May 7, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

@aeneasr
Copy link
Member Author

aeneasr commented May 7, 2024

These two need to be merged:

nextauthjs/next-auth#10843
nextauthjs/next-auth-example#99

@aeneasr
Copy link
Member Author

aeneasr commented May 7, 2024

Once merged I would add a notice to the older next js guide that we recommend using next auth instead as the integration is better than with the ory/integrations package.

We should probably de-list the old next-js guide when we do that.

@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants