Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button with formnovalidate #152

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix: button with formnovalidate #152

merged 2 commits into from
Sep 29, 2023

Conversation

Benehiko
Copy link
Contributor

Fixes Recovery, Verification and one-time code resend button. Adds the formnovalidate property based on the label id.

I've added tests for this now to catch such regressions in the future.
Since this is a UI only implementation it was hard to catch.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Benehiko Benehiko merged commit a752187 into main Sep 29, 2023
10 checks passed
@Benehiko Benehiko deleted the fix-formnovalidate-button branch September 29, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants